Fix EconomicEventItem type: add period, make comparison nullable#14
Merged
Conversation
… nullable - Add `period: string | null` — API returns period (e.g., "May", "Q1") but the type definition was missing it entirely - Change `comparison: string` → `string | null` — API returns null when no comparison type applies Fixes SUPPORT-963 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
period: string | nullfield toEconomicEventIteminterfacecomparisonfromstringtostring | null— API returnsnullwhen no comparison type appliesProblem
User reported that the
economicEventsresponse type is missing theperiodfield (e.g., "May", "Q1") andcomparisoncan benullbut was typed asstringonly.Fixes SUPPORT-963
Test plan
npm run build— passesnpm run test:unit— 210 tests passnpm run test:smoke— verify live API response matches updated types