refactor(transformations): simplify schema inheritance and split files #1143
+162
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eritance - Split transformation-steps.ts and transformations.ts - Remove TransformationStepBase: V1 defines all fields, V2 extends V1 - Remove TransformationBase: V1 defines container + steps, V2 extends V1 - TransformationV1 is now arktype validator (was plain TS type) - Factory functions return alias types (Transformation, TransformationStep) - Inline migrateStepV1ToV2 into .pipe() callback Schema shapes and migration behavior unchanged.
Contributor
🚀 Preview Deployment Ready!Whispering Preview: https://whispering-pr-1143.epicenter.workers.dev Worker Name: This preview will be automatically updated with new commits to this PR. Built with commit 5d432f7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the transformation schema definitions to be cleaner and more maintainable, without changing any actual schema shapes or migration behavior.
The original structure used shared "Base" types (
TransformationStepBase,TransformationBase) that both V1 and V2 derived from. This was defensive design for a hypothetical V3 that might need different base fields, but added unnecessary indirection.The new structure uses direct inheritance: V1 defines all fields inline, V2 extends V1 via
.merge(). This reads more naturally and follows YAGNI. The file is also split intotransformation-steps.tsandtransformations.tsto separate concerns.Changes:
TransformationStepBase: V1 now defines all fields directly, V2 extends V1TransformationBase: TransformationV1 defines container + steps, V2 extends V1TransformationV1is now an arktype validator (was plain TypeScript type)Transformation,TransformationStep) instead of explicit V2migrateStepV1ToV2function into the.pipe()callbackVerified that all schema shapes and migration behavior are unchanged.