-
-
Notifications
You must be signed in to change notification settings - Fork 235
feat(macos): add auto-pause media during recording #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
unlox775-code-dot-org
wants to merge
27
commits into
EpicenterHQ:main
Choose a base branch
from
unlox775:dave-auto-pause-resume-media
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(macos): add auto-pause media during recording #911
unlox775-code-dot-org
wants to merge
27
commits into
EpicenterHQ:main
from
unlox775:dave-auto-pause-resume-media
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds automatic media pause/resume functionality for macOS users during recording sessions. When enabled, Whispering will automatically pause Apple Music and Spotify when starting a recording and resume them when the recording stops or is canceled.
Type of Change
feat: New featurefix: Bug fixdocs: Documentation updaterefactor: Code refactoring (no functional changes)perf: Performance improvementtest: Test additions or changeschore: Maintenance tasksstyle: Code style changesChanges Made
This implementation adds a macOS-only feature that automatically pauses active media (Apple Music and Spotify) when starting a recording and resumes them when recording stops or is canceled.
Key Components Added:
sound.autoPauseMediaDuringRecordingsetting (default: true) with macOS-only UI toggle in Sound Settingsmacos_pause_active_media: Detects and pauses currently playing Music/Spotify appsmacos_resume_media: Resumes previously paused appsFiles Modified:
apps/whispering/src-tauri/src/lib.rs- Added Tauri command registrationapps/whispering/src-tauri/src/macos_media.rs- New macOS media control implementation using AppleScriptapps/whispering/src/lib/query/commands.ts- Added media control commandsapps/whispering/src/lib/query/index.ts- Exported media commandsapps/whispering/src/lib/query/media.ts- New media control module with pause/resume logicapps/whispering/src/lib/settings/settings.ts- Added auto-pause setting with default valueapps/whispering/src/routes/(config)/settings/+page.svelte- Added Sound settings navigationapps/whispering/src/routes/(config)/settings/sound/+page.svelte- Added macOS-only toggle for auto-pause featureTesting
Desktop App Testing
General Testing
Feature-Specific Testing
Checklist
typeinstead ofinterfacein TypeScriptScreenshots/Recordings
The feature adds a new toggle in Sound Settings (macOS only):
Additional Notes
Implementation Details
osascriptto control Music and Spotify appsFuture Considerations
Known Limitations