vault-architecture-v1 #912
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colecrouter
force-pushed
the
new-adapter-architecture
branch
2 times, most recently
from
3952ae3 to
78d8581
Compare
Member
|
HUGE |
Member
|
I'm getting a runtime import error: Steps to reproduce:
Based on docs in this README
|
Leftium
reviewed
Oct 25, 2025
apps/vault-demo/README.md
Outdated
|
|
||
| ``` | ||
| bun install | ||
| bun run dev -w apps/vault-demo |
Member
There was a problem hiding this comment.
This doesn't work in this repo. Should be bun run dev --filter=vault-demo
Member
|
Got my reddit data and tried to run the other demo app, but that has import problems, as well: 
|
Co-Authored-By: Leftium <[email protected]>
colecrouter
force-pushed
the
new-adapter-architecture
branch
from
78d8581 to
e15d721
Compare
Contributor
Author
|
Thanks @Leftium, there were some transient dependencies. I updated Bun for I just tested |
# Conflicts: # bun.lock # packages/vault-core/src/adapters/reddit/src/config.ts # packages/vault-core/src/adapters/reddit/src/index.ts # packages/vault-core/src/adapters/reddit/src/upsert.ts # packages/vault-core/src/core/adapter.ts
Resolved merge conflicts from merging main into new-adapter-architecture branch. Changes: - Fixed @repo/shared import to use .js extension for ESM compatibility - Updated reddit adapter index.ts to export from ./adapter - Accepted main's changes for config.ts (underscore prefix on unused var) - Kept HEAD's adapter.ts type definitions, removed test code - Removed deleted upsert.ts file - Formatted adapter.ts and db.ts with prettier The API package has pre-existing drizzle-orm version issues that are unrelated to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vault-corepackageapps/vault-demousing SvelteKit remote functionsThere's a lot here, so I recommend reading the spec or the readme.
Edit: There's a lot going on here, and I realize that some documentation might've slipped through the cracks. Depending on how much of this code gets merged/reused, I will rewrite most of the docs with the present in mind. In the meantime, if anyone notices any inconsistencies or has any questions, please let me know.