Tests for speechbrain tutorial #1007
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouthilx
reviewed
Dec 14, 2022
bouthilx
reviewed
Dec 14, 2022
bouthilx
reviewed
Dec 14, 2022
bouthilx
reviewed
Dec 14, 2022
| output = data / "results" | ||
|
|
||
| """Calling the script, for downloading the data""" | ||
| script = os.path.abspath("examples/speechbrain_tutorial/download_data.py") |
There was a problem hiding this comment.
This would be more robust if it would start from this modules directory and get the relative path. Otherwise this test only works if we executed it from repo's root.
There was a problem hiding this comment.
Not sure I understand what do you mean here. Were you thinking something like str(os.path.dirname(os.path.abspath(__file__))) + "/../../speechbrain_tutorial/main.py" ?
Simnol22
force-pushed
the
sp_tutorial_tests
branch
from
573dd68 to
69f0d90
Compare
|
The pre-trained model is too large for github-actions' runner. We would need to have a local hosted runner for this. We'll take a look at this and then revisit this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic tests for the SpeechBrain model example we are adding to the doc,.
Changes
Adding of some tests, as well as a download_data.py script.
Tests
$ tox -e py38; replace38by your Python version if necessary)Documentation
Quality
$ tox -e lint)