-
-
Notifications
You must be signed in to change notification settings - Fork 215
Implement more client-sided autocomplete suggestions #1876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I'm marking this as a draft since I don't have proof-of-functionality yet. I would also like to get some eyes on this to see where I should take it from here. |
350ed74 to
e885e52
Compare
e885e52 to
44c3561
Compare
|
This PR hasn't received as much visibility as I had hoped, so I will unmark it as a draft. However, it shouldn't be merged until there's more feedback on it. |
The changes to players was made because there are likely a lot of plugins and other commands out there in the wild that have the players argument in different formats, so instead of making them all lose autocomplete suggestions, this opts to try to cover most of the common formats.
|
Proof-of-functionality: |
RobloxStudioBeta_eDvSf1ASEm.mp4it's doing this whenever i click tab, either removing the player name or switching to a different command |
|
Merge conflict :( |
This is part two of my original PR #1853, and an implementation of the suggestion in my issue #1353 (for at least the client-side portion).
The initial goal of that issue was mainly to handle the client-side, so if anyone ever wants to tackle that problem themselves, they can (but I probably won't).
This PR has both good and bad aspects.
The good:
The bad:
ParseArgfunction.Autocompletefunction.