Skip to content

Conversation

@StayBlue
Copy link
Contributor

@StayBlue StayBlue commented Apr 7, 2025

This is part two of my original PR #1853, and an implementation of the suggestion in my issue #1353 (for at least the client-side portion).

The initial goal of that issue was mainly to handle the client-side, so if anyone ever wants to tackle that problem themselves, they can (but I probably won't).

This PR has both good and bad aspects.

The good:

  • If valid autocomplete suggestions cannot be found for the given argument, it will not return any matches.
  • This iteration now passes in the command as one of the arguments.
  • This iteration now passes in the argument correctly.

The bad:

  • This implementation likely does not alleviate the concerns raised here.
    • This has a lot of Regex that runs every time you type something into any argument field (which, by the way, I generated with AI, so I have no idea if it even works beyond what I tested).
  • This implementation is over-engineered for the job, especially the ParseArg function.
    • This trades performance for extensibility.
  • There's a lot of logic in the Autocomplete function.
    • It might benefit from some more abstraction.
  • This implementation (still) only does anything if you use the Default theme.

@StayBlue StayBlue marked this pull request as draft April 7, 2025 10:23
@StayBlue
Copy link
Contributor Author

StayBlue commented Apr 7, 2025

I'm marking this as a draft since I don't have proof-of-functionality yet. I would also like to get some eyes on this to see where I should take it from here.

@StayBlue StayBlue force-pushed the autocomplete-part-2 branch from 350ed74 to e885e52 Compare April 7, 2025 10:40
@StayBlue StayBlue force-pushed the autocomplete-part-2 branch from e885e52 to 44c3561 Compare April 7, 2025 10:55
@Expertcoderz Expertcoderz added ✨ enhancement Enhancing or improving existing functionality 📱 UI Frontend Adonis user interfaces labels Apr 18, 2025
@StayBlue
Copy link
Contributor Author

StayBlue commented May 8, 2025

This PR hasn't received as much visibility as I had hoped, so I will unmark it as a draft. However, it shouldn't be merged until there's more feedback on it.

@StayBlue StayBlue marked this pull request as ready for review May 8, 2025 23:38
@Dimenpsyonal Dimenpsyonal added the ⌛needs PoF This PR is awaiting proof of functionality label May 15, 2025
StayBlue added 2 commits May 22, 2025 22:19
The changes to players was made because there are likely a lot of plugins and other commands out there in the wild that have the players argument in different formats, so instead of making them all lose autocomplete suggestions, this opts to try to cover most of the common formats.
@StayBlue
Copy link
Contributor Author

@Dimenpsyonal Dimenpsyonal removed the ⌛needs PoF This PR is awaiting proof of functionality label Jun 10, 2025
@GalacticInspired
Copy link
Member

RobloxStudioBeta_eDvSf1ASEm.mp4

it's doing this whenever i click tab, either removing the player name or switching to a different command

@Dimenpsyonal
Copy link
Member

Merge conflict :(

@StayBlue StayBlue marked this pull request as draft August 26, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ enhancement Enhancing or improving existing functionality 📱 UI Frontend Adonis user interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants