Skip to content

Conversation

@ccuser44
Copy link
Contributor

I originally removed panic mode in #527
However with fruther thought Adonis panic mode is actually very useful in cases where Adonis fails to load properly.
And instead of just failing it still continues the loading process but enables panic mode.
This makes Adonis more resilient when bad PRs or something else break Adonis. And more future proof.

@ccuser44
Copy link
Contributor Author

@Sceleratis @Dimenpsyonal Thoughts?

@Dimenpsyonal
Copy link
Member

I would like for the formattedchangelog to be made more efficient memory-wise because the client is given a changelog and a formattedchangelog for basically no reason

@ccuser44
Copy link
Contributor Author

I would like for the formattedchangelog to be made more efficient memory-wise because the client is given a changelog and a formattedchangelog for basically no reason

Well that shouldn't be a part of this PR

@Dimenpsyonal
Copy link
Member

and yet there it is

@ccuser44
Copy link
Contributor Author

And if we did that Changelog would have to be stored somewhere else than the shared folder because the shared folder is replicated to the client

@Dimenpsyonal
Copy link
Member

or you could get rid of the formattedchangelog

@ccuser44
Copy link
Contributor Author

or you could get rid of the formattedchangelog

Well then the changelog wouldn't be formatted

@ccuser44
Copy link
Contributor Author

@Dimenpsyonal
Pof:
PROOFOFWORKPANIC

@Dimenpsyonal
Copy link
Member

whatever change you made it made the lint fail

@Dimenpsyonal Dimenpsyonal added 🖇️ loader The Adonis Loader and loader settings 🎏 miscellaneous Miscellaneous content labels Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🖇️ loader The Adonis Loader and loader settings 🎏 miscellaneous Miscellaneous content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants