-
-
Notifications
You must be signed in to change notification settings - Fork 215
Re-add panic mode #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Re-add panic mode #1905
Conversation
|
@Sceleratis @Dimenpsyonal Thoughts? |
|
I would like for the formattedchangelog to be made more efficient memory-wise because the client is given a changelog and a formattedchangelog for basically no reason |
Well that shouldn't be a part of this PR |
|
and yet there it is |
|
And if we did that Changelog would have to be stored somewhere else than the shared folder because the shared folder is replicated to the client |
|
or you could get rid of the formattedchangelog |
Well then the changelog wouldn't be formatted |
|
@Dimenpsyonal |
|
whatever change you made it made the lint fail |

I originally removed panic mode in #527
However with fruther thought Adonis panic mode is actually very useful in cases where Adonis fails to load properly.
And instead of just failing it still continues the loading process but enables panic mode.
This makes Adonis more resilient when bad PRs or something else break Adonis. And more future proof.