Skip to content

Conversation

@PurpleCreativity
Copy link
Contributor

@PurpleCreativity PurpleCreativity commented Aug 29, 2025

does not require pof

;dex is headadmins meanwhile ;s is admins and it's more powerful, it doesn't make sense.
2025-08-29-16-07-21816

EDIT: for some reason CreateStarterScript, StarterScripts and RemoveStarterScript did not check for settings.CodeExecution, which is now also a part of this pr

@PurpleCreativity
Copy link
Contributor Author

wait im dumb i should just move them from the admins file

@GalacticInspired
Copy link
Member

I am afraid that this might harm groups that use this properly.

@PurpleCreativity
Copy link
Contributor Author

I am afraid that this might harm groups that use this properly.

If not this, then i'll make a seperate pr just for the codeexecution check on CreateStarterScript, StarterScripts and RemoveStarterScript

@duckymomo360
Copy link
Contributor

I am afraid that this might harm groups that use this properly.

For that case, they could just override the permission level through settings.

I agree that running scripts should be a higher rank than admins. I also could've sworn it was higher before. It doesn't make sense to give the third highest rank a command that can do literally anything

@PurpleCreativity
Copy link
Contributor Author

I am afraid that this might harm groups that use this properly.

For that case, they could just override the permission level through settings.

I agree that running scripts should be a higher rank than admins. I also could've sworn it was higher before. It doesn't make sense to give the third highest rank a command that can do literally anything

@GalacticInspired an announcement could be always made regarding the change, I believe it's a fine sacrifice for the greater good

@PurpleCreativity
Copy link
Contributor Author

PurpleCreativity commented Sep 1, 2025

I would ask for comment from the other maintainers too regarding this (request a PR review from them)

@Dimenpsyonal Dimenpsyonal added the ⚡ command Specific Adonis commands label Sep 1, 2025
@ccuser44
Copy link
Contributor

I think the intention behind this was good but in the real world there are no tangible benefits with only drawbacks. If it's not broken, don't fix it.
I don't think most people realise that Script execution is already disabled by default. And thus for the vast majority of games there is no tangible benefit from this change.
The games that have gone out of their way to specifically enable CodeExecution already know what they're doing and don't want it changes, and the ones that do would have already done so.

Copy link
Collaborator

@coasterteam coasterteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think these should definitely be higher than Admins, if it were up to me these should be Creators+ only but this works too.

Copy link
Contributor

@P3tray P3tray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be HeadAdmin, but I don't agree with them being Creator+, that's daft.

It still doesn't sit right with me, because of the history, but meh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚡ command Specific Adonis commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants