-
-
Notifications
You must be signed in to change notification settings - Fork 215
refactor: change codeexecution commands level from admins to headadmins #1976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor: change codeexecution commands level from admins to headadmins #1976
Conversation
|
wait im dumb i should just move them from the admins file |
|
I am afraid that this might harm groups that use this properly. |
If not this, then i'll make a seperate pr just for the codeexecution check on CreateStarterScript, StarterScripts and RemoveStarterScript |
For that case, they could just override the permission level through settings. I agree that running scripts should be a higher rank than admins. I also could've sworn it was higher before. It doesn't make sense to give the third highest rank a command that can do literally anything |
@GalacticInspired an announcement could be always made regarding the change, I believe it's a fine sacrifice for the greater good |
|
I would ask for comment from the other maintainers too regarding this (request a PR review from them) |
|
I think the intention behind this was good but in the real world there are no tangible benefits with only drawbacks. If it's not broken, don't fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think these should definitely be higher than Admins, if it were up to me these should be Creators+ only but this works too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be HeadAdmin, but I don't agree with them being Creator+, that's daft.
It still doesn't sit right with me, because of the history, but meh.
does not require pof
;dex is headadmins meanwhile ;s is admins and it's more powerful, it doesn't make sense.

EDIT: for some reason CreateStarterScript, StarterScripts and RemoveStarterScript did not check for settings.CodeExecution, which is now also a part of this pr