Skip to content

Conversation

@xBaconEgg
Copy link

Block all tables inside the blacklisted table,not just the blacklisted table

PoF:
TestCode:
スクリーンショット 2025-09-09 014304
Before:
RobloxScreenShot20250908_214842495
After:
RobloxScreenShot20250908_214931069

Block all tables inside the blacklisted table,not just the blacklisted table
@xBaconEgg
Copy link
Author

This is my first pull request so something might be wrong

@ccuser44
Copy link
Contributor

Is this a vulnerability though?

@xBaconEgg
Copy link
Author

MakeScript is in DS_BlackList but MakeScript Args and AdminLevel(Only if it was settings.Permissions "s:200,300") is Accessible

@P3tray
Copy link
Contributor

P3tray commented Oct 21, 2025

@xBaconEgg I don't understand this at all. Could you please explain thoroughly what the vulnerability was, what the user could do, and how this fixes it?

Please give a paragraph explaining how someone would abuse this vulnerability, i.e. what they need to do in game.

@xBaconEgg
Copy link
Author

@P3tray
Vulnerabilit:
Unauthorized access to nested tables in DS_Blacklist
Severity:
Low
Impact:
Bypass of blacklist restrictions, unauthorized command access
Root Cause:
The old code only checks for exact matches:
-- Old Code
if ds_blacklist[displayName] then
return
end
This fails to block nested table references.
Fix:
Pattern-based check for nested table references(string.match(displayName,^{i}))

@Dimenpsyonal Dimenpsyonal added ⚡ command Specific Adonis commands 🎏 miscellaneous Miscellaneous content and removed ⚡ command Specific Adonis commands labels Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎏 miscellaneous Miscellaneous content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants