[Snyk] Security upgrade webpack-dev-server from 4.15.2 to 5.2.4#9
[Snyk] Security upgrade webpack-dev-server from 4.15.2 to 5.2.4#9Eric-Guo wants to merge 2 commits into
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-WEBPACKDEVSERVER-16642067
There was a problem hiding this comment.
Pull request overview
This PR attempts to remediate a webpack-dev-server vulnerability by upgrading the package version used by the Rails/Shakapacker frontend toolchain.
Changes:
- Updates
webpack-dev-serverinpackage.jsonfrom^4.15.2to^5.2.4. - Includes an unrelated
Gemfile.lockpatch update fordevise.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
package.json |
Updates the webpack-dev-server dependency constraint. |
Gemfile.lock |
Updates the locked devise patch version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "webpack-assets-manifest": "^5.2.1", | ||
| "webpack-cli": "^6.0.1", | ||
| "webpack-dev-server": "^4.15.2", | ||
| "webpack-dev-server": "^5.2.4", |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 792269e3da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "webpack-assets-manifest": "^5.2.1", | ||
| "webpack-cli": "^6.0.1", | ||
| "webpack-dev-server": "^4.15.2", | ||
| "webpack-dev-server": "^5.2.4", |
There was a problem hiding this comment.
Regenerate pnpm lockfile for this dependency bump
Updating webpack-dev-server in package.json without updating pnpm-lock.yaml leaves the lockfile pinned to webpack-dev-server@4.15.2 (root importer still has specifier: ^4.15.2), so this change is not installable in CI because .github/workflows/rubyonrails.yml runs pnpm install --frozen-lockfile. In that environment the install step fails before tests, and the security upgrade is not actually applied.
Useful? React with 👍 / 👎.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-WEBPACKDEVSERVER-16642067
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.