Added SCTE35 TimeDescriptor, fixed segmentation descriptor without sub_segment_num and sub_segments_expected #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you very much for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have found a bug in SCTE35, segmentation descriptor parser
It always expect to have sub_segment_num and sub_segments_expected.
According to scte 35 - 2022b 10.3.3.1
Note: sub_segment_num and sub_segments_expected can form an optional appendix to the segmentation descriptor. The presence or absence of this optional data block is determined by the descriptor loop’s descriptor_length.
I also found that you don't have time_descriptor for scte35, so I added one.
As attachment - the packet that gives the error
NUT_scte35-test_packet.zip