Repository navigation
Fix guideline statistics checker chip rows collapsing - #5185
Open
gulyasgergely902 wants to merge 2 commits into
Open
gulyasgergely902 wants to merge 2 commits into
gulyasgergely902 wants to merge 2 commits into
Conversation
Previously when a checker's enabled run count, disabled run count and somehow the unknown run count is 0, the chip was missing and it made the row collapse. This change adds a no information chip where there is no information available for the checker which makes it have the same height and informs the user of the fact. It makes easier to read the lines too.
Add a legend to the tables where the count chips are used which are Guideline Statistics, Checker Coverage Statistics and Analysis Info modal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the rows have the same height if it have no information of a given checker (not in enabled state, disabled state or unknown state). This makes it easier to understand which chip goes with which checker in the rows.
This change also adds a legend to the tables which uses the CountChips component for the users to have a better understanding which one means what without hovering on each in the table.