Repository navigation
fix(web): hide Unreviewed from the review status rule form - #5187
Open
pcbeingused333 wants to merge 2 commits into
Open
pcbeingused333 wants to merge 2 commits into
pcbeingused333 wants to merge 2 commits into
Conversation
The rule dialog offered "Unreviewed" but its validator (!!v) rejects the enum value 0, so choosing it produced "Review status is required". Unreviewed is not a meaningful rule status, so exclude it from the form's select via a new excludeUnreviewed prop; filters keep all statuses. Fixes Ericsson#5048 Signed-off-by: Alex Castillo <alex.castillog33@gmail.com>
pcbeingused333
requested review from
bruntib and
gulyasgergely902
as code owners
November 10, 2026 05:44
The generated report_server_types.js lives outside vue-cli, so its
require('thrift') was not found when the new unit test imported it.
Add vue-cli's node_modules to jest modulePaths.
Signed-off-by: Alex Castillo <alex.castillog33@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5048
Summary
The "New/Edit review status rule" dialog listed every
ReviewStatusin its select, includingUnreviewed(enum value0). The dialog's validator isv => !!v || "Review status is required", so choosingUnreviewedwas rejected with "Review status is required" even though a value had been picked.As suggested by @bruntib in the issue,
Unreviewedis removed from this form instead of changing the validator or the semantics ofgetReviewStatusRules.SelectReviewStatusgets anexcludeUnreviewedprop (defaultfalse), onlyEditReviewStatusRuleDialogsets it, so the report and rule filters still offer all statuses.Test
New
SelectReviewStatus.test.js(jest) checks that all statuses are offered by default and thatUnreviewedis omitted, with the remaining statuses intact, whenexcludeUnreviewedis set. The second case fails without the change and passes with it;eslint src/components/ReviewStatusis clean.This change and its regression test were prepared with AI assistance.