Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates packaged reverse-engineering tools and adjusts Postgres routine scaffolding code generation to produce valid C# in more edge cases.
Changes:
- Updated bundled
efreveng*.exe.ziptool artifacts undersrc/GUI/lib/. - Fixed Postgres procedure scaffolding to generate a correctly-typed (and empty-safe) parameters array.
- Fixed async method signature generation to avoid emitting an invalid leading comma when there are no procedure parameters.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/GUI/lib/efreveng90.exe.zip | Updated bundled reverse engineering executable package (binary). |
| src/GUI/lib/efreveng80.exe.zip | Updated bundled reverse engineering executable package (binary). |
| src/GUI/lib/efreveng100.exe.zip | Updated bundled reverse engineering executable package (binary). |
| src/Core/RevEng.Core.80/ServiceProviderBuilder.cs | No functional change; whitespace-only formatting in SQLite provider setup block. |
| src/Core/RevEng.Core.80/Routines/Procedures/PostgresStoredProcedureScaffolder.cs | Ensures generated Postgres routine code compiles with zero parameters and produces valid async signatures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3402