ci: run lint, test, and build on every PR

[ErnieAtLYD]

Why

There was no .github/workflows/. 159 tests across 13 files, and nothing ran them but a laptop. Every "tests pass" claim in this repo has been a local claim.

What

One job — checkout → npm ci → lint → test → build — on pull_request and pushes to main.

One job, not three. The whole suite is roughly four seconds of real work (vitest ~0.8s, next build ~2.5s). Splitting into parallel jobs would pay the checkout + npm ci cost three times to save nothing.

No secrets required. src/env.ts validates ANTHROPIC_API_KEY lazily:

let _env: z.infer<typeof envSchema> | null = null
export function getEnv() {
  if (!_env) _env = envSchema.parse(process.env)
  return _env
}

It only runs on the first getClient() call, not at import or build time — so a keyless build is a genuine check rather than one that passes by accident. Verified by moving .env.local aside and unsetting the var:

Keyless run	Result
npm test	155 passed, 13 files
npm run build	compiled + 8/8 static pages

(The 155 vs 159 gap is just this branch being cut from main before #45's four new tests.)

Node 24 to match the Vercel production runtime. The repo pins no engines field, so this workflow is the de facto version of record — worth keeping in step if prod moves.

Lint fails on errors only. eslint exits 0 on warnings by design, and there are 3 pre-existing ones (_bt/_bh in ReviewForm.tsx, plus a stray .remember/tmp/ scratch file that arguably shouldn't be linted at all). Adding --max-warnings=0 today would fail the run on day one; the comment in the file notes where to tighten once they're cleared.

concurrency with cancel-in-progress so a rapid second push doesn't leave an obsolete run burning minutes, and permissions: contents: read since nothing here needs write.

Note on merge order

This PR and #45 both branch from the same commit. Whichever lands second will be the first to actually get a CI run — #45's four new tests included.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
substack2eec	Ready	Preview	Aug 6, 2026 4:39pm