Skip to content

Type Checking and Linting improvements#62

Draft
varchasgopalaswamy wants to merge 4 commits into
Erotemic:mainfrom
varchasgopalaswamy:main
Draft

Type Checking and Linting improvements#62
varchasgopalaswamy wants to merge 4 commits into
Erotemic:mainfrom
varchasgopalaswamy:main

Conversation

@varchasgopalaswamy

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.92308% with 215 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.54%. Comparing base (c551162) to head (68d3818).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
mkinit/static_mkinit.py 73.55% 49 Missing and 15 partials ⚠️
mkinit/_tokenize.py 42.00% 52 Missing and 6 partials ⚠️
mkinit/dynamic_mkinit.py 67.79% 31 Missing and 7 partials ⚠️
mkinit/util/util_import.py 54.05% 13 Missing and 4 partials ⚠️
mkinit/__main__.py 0.00% 15 Missing ⚠️
mkinit/formatting.py 87.91% 5 Missing and 6 partials ⚠️
mkinit/static_analysis.py 70.00% 6 Missing ⚠️
mkinit/top_level_ast.py 68.75% 1 Missing and 4 partials ⚠️
mkinit/util/util_diff.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   67.53%   64.54%   -3.00%     
==========================================
  Files          11       10       -1     
  Lines        1654     1554     -100     
  Branches      389      380       -9     
==========================================
- Hits         1117     1003     -114     
- Misses        468      474       +6     
- Partials       69       77       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@varchasgopalaswamy

Copy link
Copy Markdown
Contributor Author

I pulled in a ruff config that I use in many of my work projects here. If you don't like e.g. the double vs single string change, can revert it.

@varchasgopalaswamy
varchasgopalaswamy marked this pull request as draft April 14, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant