Add an exception for extendedFieldName #763
Open
Mr14huashao wants to merge 3 commits intoEsotericSoftware:masterfrom
Open
Add an exception for extendedFieldName #763Mr14huashao wants to merge 3 commits intoEsotericSoftware:masterfrom
Mr14huashao wants to merge 3 commits intoEsotericSoftware:masterfrom
Conversation
Collaborator
|
@Mr14huashao: As I said in #759, we need a solution with minimal overhead. Ideally, the duplicate field check would be done only once when the serializer is first initialized. I think we should only log a warning so we do not break existing applications and force them to use |
theigl
requested changes
Aug 30, 2020
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java
Outdated
Show resolved
Hide resolved
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java
Outdated
Show resolved
Hide resolved
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java
Outdated
Show resolved
Hide resolved
test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java
Outdated
Show resolved
Hide resolved
Author
|
@theigl Thank you for checking my code. |
theigl
requested changes
Sep 17, 2020
Collaborator
theigl
left a comment
theigl
left a comment
There was a problem hiding this comment.
@Mr14huashao: Sorry for the delay. I just reviewed your PR.
Please adjust your tests to use existing support from KryoTestCase and change your tests to look like others in the same file.
test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java
Outdated
Show resolved
Hide resolved
test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java
Outdated
Show resolved
Hide resolved
test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java
Outdated
Show resolved
Hide resolved
test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java
Outdated
Show resolved
Hide resolved
test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java
Outdated
Show resolved
Hide resolved
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java
Outdated
Show resolved
Hide resolved
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java
Outdated
Show resolved
Hide resolved
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java
Outdated
Show resolved
Hide resolved
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java
Outdated
Show resolved
Hide resolved
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java
Outdated
Show resolved
Hide resolved
Mr14huashao
force-pushed
the
kryo-699
branch
from
6314632 to
36f99dd
Compare
Mr14huashao
force-pushed
the
kryo-699
branch
from
36f99dd to
40bcfae
Compare
theigl
reviewed
Sep 22, 2020
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java
Outdated
Show resolved
Hide resolved
theigl
reviewed
Sep 22, 2020
test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java
Outdated
Show resolved
Hide resolved
Mr14huashao
force-pushed
the
kryo-699
branch
from
40bcfae to
f152a70
Compare
Collaborator
|
@Mr14huashao: I'm currently trying to stabilize Kryo 5.0.0 and will merge only bug fix PRs in the near future. Let's revisit this after Kryo 5.0.1 has been released. |
Author
|
@theigl Do I want to modify some content based on the current version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test case about boolean field for #699