[godot] Addresses #2899, #2980, #2985#2996
Merged
lukeeingram merged 3 commits into4.2from Dec 16, 2025
Merged
Conversation
Addresses the loader/saver registration issue in #2899. Additionally, makes it such that you can adjust the SpineSkeletonData in the inspector without crashes. This appears to have been caused by a dangling pointer. Finally, double-clicking on JSON in the inspector opens the text editor and does not crash the Godot editor.
Additionally, CI builds were failing due to the commit where SpineSkin had an init() method added, but this caused Godot 3.x builds to fail. Our formatter was also run, so it should no longer fail the format check.
This was referenced Dec 15, 2025
badlogic
added a commit
that referenced
this pull request
Dec 16, 2025
Port from 4.2 branch (PR #2996): - Fix dangling pointer in SpineSkeletonDataResource destructor by using ObjectID validation instead of direct EditorFileSystem access - Register format loaders/savers at CORE level for GDExtension to fix loader/saver registration issues (#2899) Additional fix for GDExtension: - Fix crash on editor shutdown by properly removing import/inspector plugins in NOTIFICATION_PREDELETE before the extension is unloaded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the loader/saver registration issue in #2899.
Additionally, makes it such that you can adjust the SpineSkeletonData in the inspector without crashes. This appears to have been caused by a dangling pointer.
Finally, double-clicking on JSON in the inspector opens the text editor and does not crash the Godot editor.