Update styling for HexDump
#216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report for Espresso Block Explorer Components (./packages/espresso-block-explorer-components/)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
The entire hex dump area is selectable and copyable without being able to easily distinguish between the byte offset section, and the byte contents themselves. It could help to be able to select these fields independently, as it's likely unnecessary to grab the byte offset when attempting to copy or read data. This change splits the byte offsets from the byte contents themselves, and adds a separate coloring track for the byte offsets.
Ayiga
force-pushed
the
ts/enh/hex-dump-styling
branch
from
9eb301e to
14a36d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Updates the
HexDumpcomponent to have separate elements for the byte offsets and the byte contents themselves. This is useful for text selection.Additionally, the byte offset track is colored separately to allow for easier distinction.