fix: replace deprecated #[clap(...)] with #[command(...)] and #[arg

[Himess]

Closes #2826
Ref : #2827 (comment)

This PR:

-Replaces deprecated #[clap(...)] attributes with the updated #[arg(...)], #[command(...)], and #[arg(value_name = ...)] formats throughout the codebase.

-Cleans up redundant/default attributes such as:

#[arg(action)] → removed, since action is now the default in clap v4

#[arg(value_parser)] → removed, also default now

Replaces all #[arg(name = "...")] with #[arg(value_name = "...")] as per current best practices

This PR does not:

-Introduce any logic changes beyond the attribute replacements
-Refactor surrounding CLI parsing logic

Key places to review:

-All CLI argument definitions using #[arg(...)]

-Replacements of name = "...“ with value_name = "..."

-Removed empty or default action and value_parser usages

Things tested

cargo check

cargo check --features clap/deprecated

cargo build

✅ All tests passed successfully.

[Himess]

@sveitser Could you check this ? There are no conflicts now.

[sveitser]

Why change name to id?

[Himess]

For this.

[sveitser]

Shouldn't we use value_name then?

[Himess]

@sveitser Yes, you're right. I updated name to value_name as you suggested.

[Himess]

@sveitser Could you run CI again ? I force pushed branch for fmt.

[sveitser]

Please never force push to a branch after having received a review. We need to review everything again.

[sveitser]

Also there is more to fix on your branch now, since code has been added recently:

cargo check --features clap/deprecated                                                                                   0.024s  pr/3224  ❄  09:34:39
   Compiling sequencer v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/sequencer)
    Checking sequencer-utils v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/utils)
    Checking espresso-types v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/types)
    Checking espresso-contract-deployer v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/contracts/rust/deployer)
    Checking marketplace-solver v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/marketplace-solver)
    Checking client v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/client)
    Checking node-metrics v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/node-metrics)
warning: use of deprecated function `<DeployedContracts as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`
  --> contracts/rust/deployer/src/lib.rs:72:7
   |
72 |     #[clap(long, env = Contract::Timelock)]
   |       ^^^^
   |
   = note: `#[warn(deprecated)]` on by default

warning: `espresso-contract-deployer` (lib) generated 1 warning
    Checking hotshot-state-prover v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/hotshot-state-prover)
    Checking staking-cli v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/staking-cli)
    Checking diff-test-hotshot v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/contracts/rust/diff-test)
    Checking gen-vk-contract v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/contracts/rust/gen-vk-contract)
    Checking builder v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/builder)
    Checking marketplace-builder v0.1.0 (/home/lulu/r/EspressoSystems/espresso-network/marketplace-builder)
warning: use of deprecated function `<ns_aggregator::Options as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`
  --> sequencer/src/bin/utils/ns_aggregator.rs:14:7
   |
14 |     #[clap(short, long, default_value = "0")]
   |       ^^^^
   |
   = note: `#[warn(deprecated)]` on by default

warning: use of deprecated function `<ns_aggregator::Options as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`
  --> sequencer/src/bin/utils/ns_aggregator.rs:21:7
   |
21 |     #[clap(short, long)]
   |       ^^^^

warning: use of deprecated function `<ns_aggregator::Options as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`
  --> sequencer/src/bin/utils/ns_aggregator.rs:25:7
   |
25 |     #[clap(short, long)]
   |       ^^^^

warning: use of deprecated function `<ns_aggregator::Options as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`
  --> sequencer/src/bin/utils/ns_aggregator.rs:32:7
   |
32 |     #[clap(short, long, default_value = "1")]
   |       ^^^^

warning: `sequencer` (bin "utils") generated 4 warnings
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.70s

Why not enable the deprecated feature by default so everyone gets warnings if they use deprecated features? At least as dev dependency? Otherwise we will just see deprecated features being added again.

[Himess]

Hi @sveitser , I will force pushed (because so mony conflicts here.) branch. After that i can open other PR to solve if you accepted.
Why not enable the deprecated feature by default so everyone gets warnings if they use deprecated features? At least as dev dependency? Otherwise we will just see deprecated features being added again.

[Himess]

Hi @sveitser, It's ready for review now.
Also, I added a CI check for clap deprecation warnings:

- name: Check if deprecated clap feature triggers warnings
        run: |
          cargo clippy --workspace --all-targets --no-default-features --features clap/deprecated \
          -- -D warnings

[Himess]

@sveitser Could you check again ?

[Himess]

@sveitser Could you check ?

[sveitser]

I don't think it's necessary to run clippy twice with different features, please remove this.

[Himess]

Done sir.

[sveitser]

Your PR unexpectedly changes the contract bytecode.

[Himess]

I believe this change isn't part of my PR — I haven’t touched lightclientarbitrumv2.rs, and it also doesn’t appear under “Files changed”. Most likely, this was introduced by a previous merge from main.

[Himess]

@sveitser Ready for review sir.