DA stake table endpoint #3700
Merged
DA stake table endpoint #3700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pls148
requested review from
bfish713,
imabdulbasit,
jbearer,
lukaszrzasik,
rob-maron,
ss-es and
sveitser
as code owners
ss-es
requested changes
Oct 30, 2025
Contributor
ss-es
left a comment
ss-es
left a comment
There was a problem hiding this comment.
I think the da stake table by epoch endpoint should be simplified (just naively query the membership coordinator, without a cur_epoch guard or catchup). looks good to me otherwise
sequencer/src/api.rs
Outdated
Comment on lines
303
to
316
| let highest_epoch = self | ||
| .consensus() | ||
| .await | ||
| .read() | ||
| .await | ||
| .cur_epoch() | ||
| .await | ||
| .map(|e| e + 1); | ||
| if epoch > highest_epoch { | ||
| return Err(anyhow::anyhow!( | ||
| "requested DA stake table for epoch {epoch:?} is beyond the current epoch + 1 \ | ||
| {highest_epoch:?}" | ||
| )); | ||
| } |
Contributor
There was a problem hiding this comment.
for the DA stake table by epoch, I think this is not necessary. we can just query for the future DA stake table (and actually, it would be useful to not block requests far in the future, since we can use this to see that the upgrade took effect and the DA change was correctly applied)
sequencer/src/api.rs
Outdated
Comment on lines
317
to
324
| let mem = self | ||
| .consensus() | ||
| .await | ||
| .read() | ||
| .await | ||
| .membership_coordinator | ||
| .stake_table_for_epoch(epoch) | ||
| .await?; |
Contributor
There was a problem hiding this comment.
this is not necessary, we don't need to trigger catchup and should just query the membership coordinator directly
pls148
force-pushed
the
ps/da-stake-table-endpoint
branch
2 times, most recently
from
0e71788 to
30613ee
Compare
pls148
force-pushed
the
ps/da-stake-table-endpoint
branch
from
30613ee to
95ae5d3
Compare
bfish713
pushed a commit
that referenced
this pull request
Nov 14, 2025
* DA stake table endpoint * fixes * remove redundant attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an endpoint for da-stake-table/:epoch and da-stake-table/current