revert to manual serialize/deserialize implementation for staketablee… #3735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pls148
requested review from
bfish713,
imabdulbasit,
jbearer,
lukaszrzasik,
rob-maron,
ss-es and
sveitser
as code owners
Contributor
imabdulbasit
left a comment
imabdulbasit
left a comment
There was a problem hiding this comment.
I think if the serde derive implementation is able to successfully deserialize the legacy events. Then we can remove all of the legacy types, and as well as the stake table events migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vents
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review: