Prepopulate all Reward Accounts with 0 after Upgrade #3765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfish713
changed the title
bfish713
requested review from
imabdulbasit,
jbearer,
lukaszrzasik,
pls148,
rob-maron,
ss-es and
sveitser
as code owners
sveitser
reviewed
Nov 21, 2025
Co-authored-by: Mathis <[email protected]>
imabdulbasit
approved these changes
Dec 3, 2025
imabdulbasit
requested changes
Dec 3, 2025
|
|
||
| // If we just upgraded to V4 from any version we should pre-populate the merkle tree | ||
| // with accounts from the stake table, giving each address 0 initial balance | ||
| if version >= DrbAndHeaderUpgradeVersion::version() |
Contributor
There was a problem hiding this comment.
oh I think this should be before
let leader = get_leader_and_fetch_missing_rewards(
instance_state,
validated_state,
parent_leaf,
view_number,
)
.await?;
so that get_leader_and_fetch_missing_rewards doesn't trigger catchup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Populates all the accounts in the Reward Merkle tree with 0 balance. This prevents us from sending a catchup request for every account the first time it gets some rewards.
This PR does not:
This doesn't prevent catchup from occurring later on, or change the amount of rewards accumulated.
Key places to review:
The code to actually add 0 balance to every potential leader and delegator in the current stake table.