Skip to content

make apply_event public #3768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imabdulbasit merged 1 commit into from
Nov 19, 2025
Merged

make apply_event public #3768

imabdulbasit merged 1 commit into from
Nov 19, 2025

Conversation

@imabdulbasit
Copy link
Contributor

@imabdulbasit imabdulbasit commented Nov 19, 2025 •
edited
Loading

Staking UI service uses it. This was made private by this PR #3687

@imabdulbasit imabdulbasit changed the title make apply_event public function make apply_event public Nov 19, 2025
sveitser
sveitser approved these changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@sveitser sveitser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably expose a better interface externally but I know we're pressed for time so this seems fine.

@imabdulbasit
Copy link
Contributor Author

imabdulbasit commented Nov 19, 2025

We should probably expose a better interface externally but I know we're pressed for time so this seems fine.

This is only used by some tests where we assert that staking UI service has correct state.

@imabdulbasit imabdulbasit merged commit 1882f9d into main Nov 19, 2025
113 of 116 checks passed
@imabdulbasit imabdulbasit deleted the ab/apply-event-public branch November 19, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sveitser sveitser sveitser approved these changes

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

@ss-es ss-es Awaiting requested review from ss-es ss-es is a code owner

@pls148 pls148 Awaiting requested review from pls148 pls148 is a code owner

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

@rob-maron rob-maron Awaiting requested review from rob-maron rob-maron is a code owner

@lukaszrzasik lukaszrzasik Awaiting requested review from lukaszrzasik lukaszrzasik is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imabdulbasit @sveitser