release-20251106 contract changes backport #3771
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove stake table events migration * address comments * fixes (cherry picked from commit 267d14a)
(cherry picked from commit 028fb63)
* add storage gap and comments * describe with frozen inheritance pattern and why no gap is added (cherry picked from commit 4ed7cac)
* renounceOwnership reverts when called * move renounceOwnership override to v1 * move renounceOwnership override to v1 (cherry picked from commit 4e80f68)
* test: regression tests for schnorr key checks * fix: mark schnorr key as used and check length * fix: update contract bindings (cherry picked from commit e2d3c52)
* stake table: emit unlock timestamp * fix: staking-cli tests * feat: stake table: add undelegation ID * rename: UndelegationClaimed -> WithdrawalClaimed * handle new events in staking-cli (cherry picked from commit cc7430a)
imabdulbasit
approved these changes
Nov 19, 2025
Contributor
imabdulbasit
left a comment
imabdulbasit
left a comment
There was a problem hiding this comment.
Because this is only cherry picking commits, so if the CI passes this PR can be merged. Although I think we should just merge main into release branch if there is no breaking change
Collaborator
Author
|
See #3772 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to self: DO NOT squash merge.