-
Notifications
You must be signed in to change notification settings - Fork 156
derive target epoch from proposal in proposal prelim validated handler #3808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sveitser
wants to merge
11
commits into
main
Choose a base branch
from
ma/hotshot-ci-stability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−3
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d03ee1d
hotshot tests: double timeouts for flaky tests
sveitser 0c96ed8
increase test timeout
sveitser db00eed
debug: use INFO log-level
sveitser 0ee7ab8
more logs
sveitser b6e62c3
try something
sveitser 87c7c1d
debug: get logs from passing CI runs
sveitser c7bcee1
cleanup: remove unnecessary fixes
sveitser 2894f74
debug: re-enable debug logs
sveitser 2d243e1
use epoch from proposal
sveitser 1b56838
verify and store EQC
sveitser 2299a13
cargo fmt
sveitser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make sure that it's a valid extended QC we should also check whether the proposal has the corresponding
next_epoch_justify_qc. You can get it with the methodnext_epoch_justify_qc()and you can check whether the two certificates correspond to each other by comparing their leaf commits. They should be the same.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should actually be able to use
handle_eqc_formedmethod to also properly store the eQC received in this way.