Parallelize reward account fetches #3815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-maron
requested review from
bfish713,
imabdulbasit,
jbearer,
lukaszrzasik,
pls148,
ss-es and
sveitser
as code owners
rob-maron
changed the title
imabdulbasit
reviewed
Dec 3, 2025
| // Wrap the task, making it wait for a semaphore permit first | ||
| let task = async move { | ||
| // Acquire the permit | ||
| let permit = semaphore.acquire().await; |
Contributor
There was a problem hiding this comment.
I think it is safe to just call unwrap() on this since this returns a result
Contributor
There was a problem hiding this comment.
This one returns the resultlet permit = semaphore.acquire().await;
so if the semaphore is dropped it can return an error, which should not happen, so we can just unwrap here
imabdulbasit
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.