check merklized state height before returning reward accounts #3816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabdulbasit
requested review from
bfish713,
jbearer,
lukaszrzasik,
pls148,
rob-maron,
ss-es and
sveitser
as code owners
jbearer
approved these changes
Dec 2, 2025
Member
|
This seems like a good candidate for a regression test |
imabdulbasit
added a commit
that referenced
this pull request
Dec 4, 2025
* check merklized state height before returning reward accounts * fix existing test and add regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query returns reward accounts where created <= requested height, but if the node's merklized state lags behind, we could return stale balances from an older height. This adds a check to ensure the reward-state-v2 has data up to the requested height before returning results, so that we return the latest account balances as of that height.