fix(staking-cli): include balance info in AlreadyClaimed error #3821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error Fixes EspressoSystems#3775 When claim_reward fails with AlreadyClaimed, the error now includes the current unclaimed balance, lifetime rewards, and already claimed amount. This helps users understand if the claim failed due to a race condition (another claim succeeded) vs a genuine error. Before: 'AlreadyClaimed()' After: 'Rewards already claimed. Current unclaimed balance: 0 (lifetime: 1000, claimed: 1000)'
madisoncarter1234
requested review from
bfish713,
imabdulbasit,
jbearer,
lukaszrzasik,
pls148,
rob-maron,
ss-es and
sveitser
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3775
When
claim_rewardfails withAlreadyClaimed, the error now includes the current unclaimed balance, lifetime rewards, and already claimed amount. This helps users understand if the claim failed due to a race condition (another claim succeeded) vs a genuine error.Before:
AlreadyClaimed()After:
Rewards already claimed. Current unclaimed balance: 0 (lifetime: 1000, claimed: 1000)