Skip to content

feat(benchmarks): Modernize benchmark script with CLI options and error handling - #719

Open
crStiv wants to merge 1 commit into
EspressoSystems:mainfrom
crStiv:enhance-benchmarks
Open

feat(benchmarks): Modernize benchmark script with CLI options and error handling#719
crStiv wants to merge 1 commit into
EspressoSystems:mainfrom
crStiv:enhance-benchmarks

Conversation

@crStiv

@crStiv crStiv commented Dec 30, 2024

Copy link
Copy Markdown

This PR addresses issue #686 by improving the benchmark script with the following enhancements:

New Features:

  • Added --benchmark option to run specific benchmarks
  • Added --threads option to control thread count
  • Added --output option to save results in CSV/JSON formats
  • Added --iterations and --warmup options to control benchmark parameters
  • Improved ASM feature control with --asm flag

Technical Improvements:

  • Implemented robust error handling
  • Added validation for input parameters
  • Improved environment configuration
  • Added support for benchmark output formats (CSV/JSON)
  • Removed dependency on argbash

User Experience:

  • Added comprehensive help documentation
  • Improved console output with clear configuration display
  • Better feedback during benchmark execution
  • Clear error messages for troubleshooting

Testing:

  • Tested with various benchmark configurations
  • Verified error handling scenarios
  • Confirmed output format functionality

This update makes the benchmark script more flexible and user-friendly while maintaining compatibility with existing functionality.

@crStiv
crStiv requested review from alxiong and mrain as code owners December 30, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant