Contract changes for Stateless Batch Poster design #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacshowa
reviewed
Mar 10, 2025
| @param signature The signature of the user data | ||
| @param userDataHash The hash of the user data | ||
| */ | ||
| function verify(bytes memory signature, bytes32 userDataHash) external view { |
There was a problem hiding this comment.
How are we planning to extend this for future tee types?
I think this function might want to match on a teeType argument to determine which verifier to check like the registerSigner function.
There was a problem hiding this comment.
ECDSA signature will be same across all Tee
There was a problem hiding this comment.
Yes but this contract will be responsible for checking multiple different potential sub contracts that could have the signer as a verified party correct? Like an instance EspressoTEEVerifier should be capable of verifying with a EspressoSGXTEEVerifier and a hypothetical EspressoNitroTEEVerifier right?
…Systems/nitro-contracts into stateless-batcher-contract-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.