Add Header to Hotshot Payload #751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sneh1999
reviewed
Sep 3, 2025
arbutil/espresso_utils.go
Outdated
| SubmittedAt time.Time `rlp:"optional"` | ||
| } | ||
|
|
||
| type Header struct { |
There was a problem hiding this comment.
can you also add comments on what each of this fields signifies?
| return err | ||
| } | ||
| case arbutil.EphemeralKey: | ||
| err := s.verifyBatchPosterSignature(data, userDataHashArr, l1Height) |
There was a problem hiding this comment.
can we create functions for each case instead of all this in one verify function?
| for _, tc := range invalidPayloads { | ||
| t.Run(tc.description, func(t *testing.T) { | ||
| _, _, _, _, err := ParseHotShotPayload(tc.payload) | ||
| _, _, _, _, err := ParseHotShotPayload(tc.payload, nil) |
There was a problem hiding this comment.
can you add a test to show that it will work with new transaction format as well as legacy?
lukeiannucci
commented
Sep 3, 2025
lukeiannucci
commented
Sep 3, 2025
Member
|
Just putting my thought for more discussion: Is it appropriate to use another hotshot namespace for timeboost transactions? In this way we don't need headers |
lukeiannucci
requested review from
ImJeremyHe,
alysiahuggins,
jbearer,
jjeangal,
sveitser and
zacshowa
as code owners
ImJeremyHe
pushed a commit
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
See design doc:
https://www.notion.so/espressosys/Espresso-Header-in-Nitro-Payloads-2642431b68e9807fa12afa5bc8fa4d35
This PR does not:
Key places to review: