-
Notifications
You must be signed in to change notification settings - Fork 22
Merge release-tee-caff-node into celestia-v3.5.6
#898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: celestia-v3.5.6
Are you sure you want to change the base?
Conversation
…ault value: `false`
Locally I have been having issues getting the code to compile with `gballet/go-verkle` due to some missing functions. I fixed this by updating my local `go-ethereum` submodule to reference the new location for this repo at `ethereum/go-verkle`, but this doesn't seem to work well for CI. I'm not sure why I'm seeing this locally tbh.
Hopefully for the last time. An erroneous go get `go-ethereum` using the version present in the go.mod file led to a dependency of one of geths dependencies being the wrong version. This lead to failures to compile geth in this PR. Learn from my mistakes, don't run `go get` on geth in this project!!
In this version celestia has lint errors. For now just leave this.
This should reset the changes to what existed in 3.5.6
|
Currently the Caff node E2E test is failing due to the state checker portion of the test. The state checker doesn't seem to be reporting an error when the test expects it to. Otherwise it looks like the test is passing. I think this is because the state checker is having an issue connecting to the node started on port 9000, but I'm not sure why it's having trouble connecting. This seems to be consistent across CI and local behavior. Additionally, for the go tests, I'm seeing failures in CI with logs only related to the |
Sneh1999
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zacshowa can you also pull in the attestation verifier changes and the namespace range endpoint changes in this PR as well?
Until the contracts are updated such that the SequencerInbox references the new espresso-tee-contracts, we need to use the legacy version for these tests.
* Integrate Attestation Verifier Service * remove redundant code * use document * fix encoding/decoding * strip 0x * remove logs * address comments
* Add Namespace Range enpoint to streamer * fix tests * fix lint * fix comment * address bot comments * fix lint
Closes Asana ticket: Merge v3.5.6 celestia branch with release-tee-caff-node
This PR:
Merges the tee-caff-node work with celestia-v3.5.6, fixes tests (some of which may not be failures related to this PR)
This PR does not:
Fix nitro tests that seem to just be failing in CI
Key places to review:
Most WIP commits that fix the tests. These fix errors in the initial merge, and fix the tests.
Primarily pay attention to things related to the
espresso_caff_node.gofile, andstaker/legacy/TestChallengeToTooFarHow to test this PR:
make test-go
All CI
Things tested
make test-go