Skip to content

Conversation

@zacshowa
Copy link
Member

@zacshowa zacshowa commented Jan 6, 2026

Closes Asana ticket: Merge v3.5.6 celestia branch with release-tee-caff-node

This PR:

Merges the tee-caff-node work with celestia-v3.5.6, fixes tests (some of which may not be failures related to this PR)

This PR does not:

Fix nitro tests that seem to just be failing in CI

Key places to review:

Most WIP commits that fix the tests. These fix errors in the initial merge, and fix the tests.

Primarily pay attention to things related to the espresso_caff_node.go file, and

staker/legacy/TestChallengeToTooFar

How to test this PR:

make test-go
All CI

Things tested

make test-go

Locally I have been having issues getting the code to compile with
`gballet/go-verkle` due to some missing functions.

I fixed this by updating my local `go-ethereum` submodule to reference
the new location for this repo at `ethereum/go-verkle`, but this doesn't
seem to work well for CI.

I'm not sure why I'm seeing this locally tbh.
Hopefully for the last time.
An erroneous go get `go-ethereum` using the version present in the
go.mod file led to a dependency of one of geths dependencies being the
wrong version. This lead to failures to compile geth in this PR.

Learn from my mistakes, don't run `go get` on geth in this project!!
In this version celestia has lint errors. For now just leave this.
This should reset the changes to what existed in 3.5.6
@zacshowa
Copy link
Member Author

zacshowa commented Jan 8, 2026

Currently the Caff node E2E test is failing due to the state checker portion of the test. The state checker doesn't seem to be reporting an error when the test expects it to. Otherwise it looks like the test is passing.

I think this is because the state checker is having an issue connecting to the node started on port 9000, but I'm not sure why it's having trouble connecting. This seems to be consistent across CI and local behavior.

Additionally, for the go tests, I'm seeing failures in CI with logs only related to the TestDatabaseConversion test, which passes just fine locally. In fact I have ran most of the tests reported as failing in CI now, and they are passing locally. I believe that TestBlockValidatorSimpleOnChainWithPublishedMachine ran for an extraordinarily long time, so I'm not sure if it's behaving correctly.

Copy link

@Sneh1999 Sneh1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zacshowa can you also pull in the attestation verifier changes and the namespace range endpoint changes in this PR as well?

zacshowa and others added 14 commits January 9, 2026 16:58
Until the contracts are updated such that the SequencerInbox references
the new espresso-tee-contracts, we need to use the legacy version for
these tests.
* Integrate Attestation Verifier Service

* remove redundant code

* use document

* fix encoding/decoding

* strip 0x

* remove logs

* address comments
* Add Namespace Range enpoint to streamer

* fix tests

* fix lint

* fix comment

* address bot comments

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants