Update iam policies#304
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates ArcGIS Enterprise ingress GitHub Actions workflows to construct Terraform backend state keys using ingress_id (instead of deployment_id) for more accurate targeting of ingress resources, and extends AWS IAM policies to allow SNS subscription lifecycle operations required by the Terraform monitoring resources.
Changes:
- Update AWS and Azure
enterprise-ingressworkflows to readingress_idfrom the Terraform var-file and use it in the backend statekey. - Add
sns:SubscribetoArcGISEnterpriseCoreIAM policy permissions. - Add
sns:UnsubscribetoArcGISEnterpriseCoreDestroyIAM policy permissions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| azure/arcgis-enterprise-core/workflows/enterprise-ingress-azure.yaml | Use ingress_id when building the Azure backend state key for ingress apply/plan. |
| azure/arcgis-enterprise-core/workflows/enterprise-ingress-azure-destroy.yaml | Use ingress_id when building the Azure backend state key for ingress destroy. |
| aws/arcgis-enterprise-core/workflows/enterprise-ingress-aws.yaml | Use ingress_id when building the S3 backend state key for ingress apply/plan. |
| aws/arcgis-enterprise-core/workflows/enterprise-ingress-aws-destroy.yaml | Use ingress_id when building the S3 backend state key for ingress destroy. |
| aws/iam-policies/ArcGISEnterpriseCore.json | Grant sns:Subscribe needed for creating SNS topic subscriptions. |
| aws/iam-policies/ArcGISEnterpriseCoreDestroy.json | Grant sns:Unsubscribe needed for cleanup during destroy. |
| "sns:GetSubscriptionAttributes", | ||
| "sns:ListTagsForResource", | ||
| "sns:SetTopicAttributes", | ||
| "sns:Subscribe", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates both AWS and Azure workflow files to use
ingress_idinstead ofdeployment_idfor identifying ingress resources, ensuring consistency and correctness in Terraform state management. Additionally, it updates IAM policies to grant the necessary SNS permissions for subscribing and unsubscribing.Workflow improvements:
enterprise-ingressworkflows for AWS and Azure now useingress_idinstead ofdeployment_idto construct the Terraform state key, ensuring the correct resource is targeted during apply and destroy operations. (aws/arcgis-enterprise-core/workflows/enterprise-ingress-aws.yaml,aws/arcgis-enterprise-core/workflows/enterprise-ingress-aws-destroy.yaml,azure/arcgis-enterprise-core/workflows/enterprise-ingress-azure.yaml,azure/arcgis-enterprise-core/workflows/enterprise-ingress-azure-destroy.yaml) [1] [2] [3] [4]IAM policy updates:
ArcGISEnterpriseCorepolicy now allows thesns:Subscribeaction, enabling subscription to SNS topics. (aws/iam-policies/ArcGISEnterpriseCore.json)ArcGISEnterpriseCoreDestroypolicy now allows thesns:Unsubscribeaction, supporting cleanup of SNS subscriptions during resource destruction. (aws/iam-policies/ArcGISEnterpriseCoreDestroy.json)