Updating service used for sample on all platforms #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williambohrmann3
approved these changes
May 13, 2025
src/Directory.Packages.props
Outdated
| @@ -1,7 +1,7 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally> | |||
| <ArcGISMapsSDKVersion Condition="'$(ArcGISMapsSDKVersion)'==''">200.7.0</ArcGISMapsSDKVersion> | |||
| <ArcGISMapsSDKVersion Condition="'$(ArcGISMapsSDKVersion)'==''">200.8.0</ArcGISMapsSDKVersion> | |||
There was a problem hiding this comment.
unrelated change
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.esri.arcgisruntime.samples.maui" android:versionCode="6" android:versionName="200.7.0"> | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.esri.arcgisruntime.samples.maui" android:versionCode="7" android:versionName="200.8.0"> | |||
There was a problem hiding this comment.
unrelated change
@williambohrmann3 I've regressed the unrelated changes in my branch, good to merge? |
|
@cgutierrez-gis yep, good to merge |
github-actions bot
pushed a commit
that referenced
this pull request
May 14, 2025
Co-authored-by: William Bohrmann <[email protected]> Co-authored-by: Carlos Gutierrez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously used service has now required a token authentication to access and Sample wasn't working, the service used has been updated based on what the Kotlin sample viewer uses.
Type of change
Platforms tested on
Checklist