Skip to content

Add permission dialog before downloading sample data #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenaak merged 2 commits into from
Feb 27, 2026
Merged

Add permission dialog before downloading sample data #1761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b28159
add permission dialog before downloading data
praveenaak Feb 26, 2026
3b89be2
fix: reset SelectedSample on download cancel to unblock sample naviga…
praveenaak Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/MAUI/Maui.Samples/Helpers/SampleLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,18 @@ public static async Task LoadSample(SampleInfo sampleInfo)
// Load offline data before showing the sample.
if (sampleInfo.OfflineDataItems != null && !await DataManager.HasSampleDataPresent(sampleInfo))
{
// Ask the user for permission before downloading.
bool download = await Application.Current.Windows[0].Page.DisplayAlert(
"Download Required",
"This sample requires data to be downloaded. Would you like to download it now?",
"Download", "Cancel");

if (!download)
{
SampleManager.Current.SelectedSample = null;
return;
}

CancellationTokenSource cancellationSource = new CancellationTokenSource();

// Show the wait page.
Expand Down
14 changes: 13 additions & 1 deletion src/WPF/WPF.Viewer/MainWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,20 @@ private async Task SelectSample(SampleInfo selectedSample)

try
{
if (selectedSample.OfflineDataItems != null)
if (selectedSample.OfflineDataItems != null && !await DataManager.HasSampleDataPresent(selectedSample))
{
// Ask the user for permission before downloading.
var result = MessageBox.Show(
"This sample requires data to be downloaded. Would you like to download it now?",
"Download Required",
MessageBoxButton.YesNo, MessageBoxImage.Question);

if (result != MessageBoxResult.Yes)
{
SampleManager.Current.SelectedSample = null;
return;
}

CancellationTokenSource cancellationSource = new CancellationTokenSource();

// Show waiting page
Expand Down
14 changes: 13 additions & 1 deletion src/WinUI/ArcGIS.WinUI.Viewer/MainPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,20 @@ private async Task SelectSample(SampleInfo selectedSample)

try
{
if (selectedSample.OfflineDataItems != null)
if (selectedSample.OfflineDataItems != null && !await DataManager.HasSampleDataPresent(selectedSample))
{
// Ask the user for permission before downloading.
var dialog = new MessageDialog2("This sample requires data to be downloaded. Would you like to download it now?", "Download Required");
dialog.Commands.Add(new Windows.UI.Popups.UICommand("Download"));
dialog.Commands.Add(new Windows.UI.Popups.UICommand("Cancel"));
var result = await dialog.ShowAsync();

if (result.Label != "Download")
{
SampleManager.Current.SelectedSample = null;
return;
}

CancellationTokenSource cancellationSource = new CancellationTokenSource();

// Show the waiting page
Expand Down
Loading