Skip to content

Enhance NewModuleScript Template #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 21, 2025
Merged

Conversation

shubham7109
Copy link
Collaborator

@shubham7109 shubham7109 commented Apr 5, 2025

Description

PR to add quality enhancements to the NewModuleScript templates.

Links and Data

Sample issue: #5667

What To Review

  • Thoughts and feedback on the 2 new sample templates.
  • Does the usage of the bottom sheet and dialog feel easy/straightforward for samples?
  • Files changed for samples-lib library

How to Test

$ java -jar tools/NewModuleScript.jar 
Enter Name of the sample with spaces (Eg. "Display new map"): 
Display TEST map
Choose the sample category: 
1:  Analysis 
2:  Augmented Reality 
3:  Cloud and Portal 
4:  Layers 
5:  Edit and Manage Data 
6:  Maps 
7:  Scenes 
8:  Routing and Logistics 
9:  Utility Networks 
10: Search and Query 
11: Visualization
Enter a number (1-11) to sample category: 1
Choose the sample template type: 
1: Basic 
2: FAB with DialogOptions 
3: FAB with SheetOptions
Enter a number (1-3) to sample template type: 2
Using repository../arcgis-maps-sdk-kotlin-samples
Sample Successfully Created! 

@shubham7109 shubham7109 changed the title Shubham/quality enhancements Enhance NewModuleScript Template Apr 11, 2025
@shubham7109 shubham7109 self-assigned this Apr 11, 2025
@shubham7109 shubham7109 marked this pull request as ready for review April 11, 2025 16:48
@shubham7109 shubham7109 added the enhancement New feature or request label Apr 11, 2025
@01smito01 01smito01 self-requested a review April 15, 2025 12:46
Copy link
Collaborator

@01smito01 01smito01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given these a test drive and think they work quite nicely. FAB -> dialogue/sheet works well as a design pattern for a lot of samples, so it's handy to have the script set it up for you.

I have a couple questions and quibbles:

@shubham7109 shubham7109 requested a review from 01smito01 April 16, 2025 02:58
Copy link
Collaborator

@01smito01 01smito01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarifications, looks good 👍

@puneet-pdx puneet-pdx self-requested a review April 17, 2025 16:58
@TADraeseke TADraeseke requested review from TADraeseke and removed request for puneet-pdx April 21, 2025 16:47
Copy link
Collaborator

@TADraeseke TADraeseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @shubham7109 -- this'll save alot of time and be a great help for new contributors. I've got a couple comments in line, but broadly the only improvement I'd suggest is to include at least one DropdownMenuItem in the template. Just so we don't have to go find the composable by name. Great work!

@shubham7109
Copy link
Collaborator Author

@TADraeseke Added in the PR feedback, and updated the tools/NewModuleScript.jar. Ready for your review.

@shubham7109 shubham7109 requested a review from TADraeseke April 21, 2025 19:05
Copy link
Collaborator

@TADraeseke TADraeseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shubham7109 shubham7109 merged commit 8f0e406 into v.next Apr 21, 2025
1 check passed
@shubham7109 shubham7109 deleted the shubham/quality-enhancements branch April 21, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants