-
Notifications
You must be signed in to change notification settings - Fork 38
Enhance NewModuleScript Template #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given these a test drive and think they work quite nicely. FAB -> dialogue/sheet works well as a design pattern for a lot of samples, so it's handy to have the script set it up for you.
I have a couple questions and quibbles:
samples-lib/src/main/java/com/esri/arcgismaps/sample/sampleslib/components/SampleDialog.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarifications, looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @shubham7109 -- this'll save alot of time and be a great help for new contributors. I've got a couple comments in line, but broadly the only improvement I'd suggest is to include at least one DropdownMenuItem
in the template. Just so we don't have to go find the composable by name. Great work!
samples-lib/src/main/java/com/esri/arcgismaps/sample/sampleslib/components/BottomSheet.kt
Outdated
Show resolved
Hide resolved
@TADraeseke Added in the PR feedback, and updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
PR to add quality enhancements to the NewModuleScript templates.
Links and Data
Sample issue: #5667
What To Review
samples-lib
libraryHow to Test