Make AR module optional for the sample viewer #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TADraeseke
approved these changes
Apr 8, 2025
| @@ -6,7 +6,9 @@ | |||
|
|
|||
| <!-- Limits app visibility in the Google Play Store to ARCore supported devices | |||
There was a problem hiding this comment.
Do we need to consider altering this comment. The line below now doesn't limit visibility in the store, but it could be a useful flag to indicate to users where/how they do limit
There was a problem hiding this comment.
I guess the comment on line 28/29 is still valid
There was a problem hiding this comment.
Updated comment to say:
<!-- Provide support for ARCore via Google Play Services,
by checking to see if device is compatible and ready for AR.
(https://developers.google.com/ar/devices). -->
|
@TADraeseke, it turns out the solution I originally had didn't resolve the issue on GooglePlay. I added a new commit change following Google's doc to make AR core optional: https://developers.google.com/ar/develop/java/enable-arcore#ar-optional Test this change on the play store, and no issues were found. Requesting a re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to make the AR module an optional module for the sample viewer and add logic to handle the scenario if the device does not support AR.
Links and Data
Sample Epic: #5638