Sample Viewer: Update dependencies #349
Merged
+22
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TADraeseke
approved these changes
Apr 22, 2025
...convention/src/main/java/com/esri/arcgismaps/kotlin/build_logic/convention/AndroidCompose.kt
Show resolved
Hide resolved
shubham7109
commented
Apr 23, 2025
Comment on lines
+21
to
+26
| // `kotlin-dsl` applied here uses embedded Kotlin version 1.9.23 for gradle wrapper 8.9 | ||
| // https://docs.gradle.org/current/userguide/compatibility.html#kotlin | ||
| // This is needed as newer versions of kotlinx-serialization has been compiled using Kotlin 2.0+ | ||
| // https://github.com/Kotlin/kotlinx.serialization/releases | ||
| // Sample modules do not use kotlin-dsl, instead uses latest kotlin serialization from libs versions. | ||
| implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3") |
There was a problem hiding this comment.
@puneet-pdx Added a comment which hope helps explains the need for the revert change to keep in sync with toolkit. Ready for your review!
puneet-pdx
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to update dependencies to aim to depend on the latest versions.
28.Links and Data
Sample isse: #5647