AttachmentsFeatureElementView - (Test & amend) Fix potential load cancellation condition#1382
Draft
dfeinzimer wants to merge 4 commits intodf/refactoringfrom
Draft
AttachmentsFeatureElementView - (Test & amend) Fix potential load cancellation condition#1382dfeinzimer wants to merge 4 commits intodf/refactoringfrom
AttachmentsFeatureElementView - (Test & amend) Fix potential load cancellation condition#1382dfeinzimer wants to merge 4 commits intodf/refactoringfrom
Conversation
dfeinzimer
changed the title
AttachmentsFeatureElementView - (Test) Fix potential load cancellation conditionAttachmentsFeatureElementView - (Test & amend) Fix potential load cancellation condition
dfeinzimer
commented
Mar 16, 2026
Comment on lines
+68
to
+77
| if models.isEmpty { | ||
| Text( | ||
| "No attachments", | ||
| bundle: .toolkitModule, | ||
| comment: """ | ||
| A label indicating an element | ||
| contains no file attachments. | ||
| """ | ||
| ) | ||
| } else { |
Collaborator
Author
There was a problem hiding this comment.
This prevents the enclosing Group from being optimized out, causing the onAttachmentIsEditableChange modifier on it to never run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AttachmentsFeatureElementView- Fix potential load cancellation condition #1381, using new members added inFeatureFormView- General refactoring #1379.