GeometryEditorToolbar - Add snap settings button#1457
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a snapping settings entry point to GeometryEditorToolbar by introducing a new toolbar button that presents a sheet (SnapSettingsView) for configuring SnapSettings (enable/disable snapping, haptics, geometry guides, feature snapping, and per-source toggles).
Changes:
- Added
SnapSettingsView(form-based UI) for configuringSnapSettingsandSnapSourceSettings. - Added a new toolbar control (
SnapSettingsButton) that conditionally appears and presents the snap settings sheet. - Minor layout tweak to use the existing
stackSpacingconstant for the horizontal stack.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Sources/ArcGISToolkit/Components/GeometryEditorToolbar/SnapSettingsView.swift |
New settings UI for snapping, including per-source toggles and rule-behavior messaging. |
Sources/ArcGISToolkit/Components/GeometryEditorToolbar/GeometryEditorToolbar.swift |
Adds the settings button + sheet presentation and updates docs/layout accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
I'll make some changes based on today's feedback |
Can you be specific with what other changes? I don't think anything needs to be done with persistence yet. I think that will be at the feature editor or app level. |

Description
This PR adds a button that presents a sheet for configuring snap settings to the
GeometryEditorToolbar.Closes
swift/issues/8165.Behavior
snapSettings.sourceSettingsis empty.Snap Source Toggles
ruleBehaviorisrulesPreventSnapping.ruleBehavior.How To Test
Note: The data in the test example doesn't have any snap rules, so the view will look different than the screenshots.
Screenshots
Platforms