GeometryEditorToolbar - Make internal#1458
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes GeometryEditorToolbar from the toolkit’s public API surface by making the component internal, and updates documentation and the Test Runner accordingly so internal access continues to work for local testing.
Changes:
- Changed
GeometryEditorToolbar(and its initializer/body/extension) frompublicto internal access. - Removed
GeometryEditorToolbarfrom the top-level DocC component list. - Updated the Test Runner view to use
@testable import ArcGISToolkitso it can access the now-internal toolbar.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Test Runner/Test Runner/TestViews/GeometryEditorToolbarTestView.swift | Switches to @testable import so the Test Runner can still instantiate the internal toolbar. |
| Sources/ArcGISToolkit/Documentation.docc/ArcGISToolkit.md | Removes the public documentation entry for GeometryEditorToolbar. |
| Sources/ArcGISToolkit/Components/GeometryEditorToolbar/GeometryEditorToolbar.swift | Makes GeometryEditorToolbar and related API elements internal and removes public doc metadata elements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yo1995
approved these changes
Jun 3, 2026
rolson
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the
GeometryEditorToolbarcomponent internal and removes related "public" doc elements.swift/issues/8223How To Test
Ensure the Test Runner project builds.