New Sample: AR Feature Layer by mmgaw113 · Pull Request #163 · Esri/arcgis-maps-sdk-unity-samples

mmgaw113 · 2024-11-26T17:50:36Z

Sample

This sample aims to bring Real-World, Location-based AR along side use of the ArcGIS Maps SDK in order to show Feature Layer data in the real world.

Checklist

ArcGIS Maps SDK Version

Maps SDK 1.7 w/ Unity 6000.0 LTS

…-unity-samples into mas12517/Update-XR-Samples # Conflicts: # sample_project/Assets/SampleViewer/Resources/InputActions/TouchControls.cs.meta # sample_project/Assets/SampleViewer/Resources/Prefabs/JoystickCanvas.prefab.meta # sample_project/Assets/SampleViewer/Samples/StreamLayer/Materials.meta # sample_project/Assets/SampleViewer/Samples/StreamLayer/Materials/BASE.mat.meta # xr_sample_project/Assets/DefaultVolumeProfile.asset.meta # xr_sample_project/Assets/SampleViewer/Resources/SampleGraphicSettings.meta # xr_sample_project/Assets/SampleViewer/Resources/SampleGraphicSettings/LightingManager.cs.meta # xr_sample_project/Assets/SampleViewer/Resources/SampleGraphicSettings/SampleHDRPipeline.asset.meta # xr_sample_project/Assets/SampleViewer/Resources/SampleGraphicSettings/URP.prefab.meta # xr_sample_project/Assets/SampleViewer/Resources/Settings/SampleURPipeline Renderer.asset # xr_sample_project/Assets/Samples/XR Hands/1.4.0.meta # xr_sample_project/Assets/Samples/XR Interaction Toolkit/3.0.5/Hands Interaction Demo/HandsDemoSceneAssets/Materials/MaterialPipelineHandler.asset.meta # xr_sample_project/Assets/Samples/XR Interaction Toolkit/3.0.5/Hands Interaction Demo/HandsDemoSceneAssets/Prefabs/AudioAffordance.prefab.meta # xr_sample_project/Assets/Samples/XR Interaction Toolkit/3.0.5/Hands Interaction Demo/Scripts/ReleaseThresholdButtonReader.cs.meta # xr_sample_project/Assets/Samples/XR Interaction Toolkit/3.0.5/Starter Assets/DemoSceneAssets/Prefabs/Climb/Multi Floor Ladder.prefab.meta # xr_sample_project/Assets/Samples/XR Interaction Toolkit/3.0.5/Starter Assets/DemoSceneAssets/Prefabs/Climb/Multi-Anchor Teleport Reticle.prefab.meta

…arcgis-maps-sdk-unity-samples into mas12517/ARSample # Conflicts: # xr_sample_project/Assets/XR/Settings/OpenXR Package Settings.asset # xr_sample_project/Packages/manifest.json # xr_sample_project/Packages/packages-lock.json

…arcgis-maps-sdk-unity-samples into mas12517/ARSample

…samples into mas12517/ARSample

…-unity-samples into mas12517/ARSample # Conflicts: # xr_sample_project/Assets/Images/LogoMenu.png.meta # xr_sample_project/Assets/Plugins/Android/proguard-user.txt.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Animations.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/GeoSpatialFeatureLayer.unity.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Images.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Images/Cancel_Icon.png.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Images/CircleMask.png.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Images/Handle.png.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Images/reset.png.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Input.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Input/ARTouchControls.cs.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Input/ARTouchControls.inputactions.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Materials.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Materials/HighLightMaterial.mat.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Materials/Shader Graphs_Outline.mat.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Materials/Shader Graphs_Transparent.mat.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Models.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Models/LocationMarker.fbx.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Models/LocationMarker.mat # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Models/LocationMarker.mat.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Prefabs.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Prefabs/FeatureData.prefab.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Prefabs/LocationMarker.prefab.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Scripts.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Scripts/ArcGISGeospatialController.cs.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Scripts/FeatureData.cs.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Scripts/FeatureLayerQuery.cs.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Settings/ARCoreExtensionsCameraConfigFilter.asset.meta # xr_sample_project/Assets/SampleViewer/Samples/GeoSpatialAR Sample/Textures.meta # xr_sample_project/Assets/XR/Settings/ARCoreSettings.asset.meta # xr_sample_project/Assets/XR/Settings/ARKitSettings.asset.meta # xr_sample_project/Packages/manifest.json # xr_sample_project/Packages/packages-lock.json

…-unity-samples into mas12517/ARSample

…samples into mas12517/ARSample

…-unity-samples into mas12517/ARSample

ZackAllen

There is no consistency in the format of the image names.

ZackAllen · 2024-12-02T21:29:02Z

+        {
+            Debug.Log("Requesting the fine location permission.");
+            Permission.RequestUserPermission(Permission.FineLocation);
+            yield return new WaitForSeconds(3.0f);


Why is this delay needed? Probably worth adding a comment explaining why.

ZackAllen · 2024-12-02T21:30:17Z

+        Debug.Log("Starting location service.");
+        Input.location.Start();
+
+        while (Input.location.status == LocationServiceStatus.Initializing)


Do we have any event we can hook into for this status change? While loop here is dangerous with no timeout.

Unfortunately no. Location Services is still under old input and isn't available in new input. So there aren't any events. A lot of this code is just safety precautions.

ZackAllen · 2024-12-02T21:41:17Z

+    [SerializeField] private Material outlineMaterial;
+
+    [Header("Mini Map")]
+    private Button expandButton;


Why is this button not serialized like the others?

It can be gotten in Awake(), The others can't

ZackAllen · 2024-12-02T21:43:09Z

+    {
+        inputField.text = featureLayerQuery.WebLink.Link;
+        menuButton.image.sprite = upSprite;
+        menuButton.GetComponentInChildren<TextMeshProUGUI>().text = "Touch to Hide Menu";


private const string should be used to avoid repeatedly having this value.

this string is being dynamically changed based on the status of the menu. It goes back and forth between "Touch to Show Menu" and "Touch to Hide Menu".

ZackAllen · 2024-12-02T21:44:10Z

+    {
+        locationComponent.Position = new ArcGISPoint(cameraController.cameraGeospatialPose.Longitude,
+            cameraController.cameraGeospatialPose.Latitude, ArcGISSpatialReference.WGS84());
+        locationComponent.Rotation = new ArcGISRotation(cameraController.cameraGeospatialPose.EunRotation.eulerAngles.y + northOffset,180,0);


Formatting doesn't look correct with commas/spaces. Definitely run formatter here.

ZackAllen · 2024-12-02T21:45:04Z

+### Deployment
+
+For deploying, please refer to this [document](https://developers.arcgis.com/unity/deployment/)
+In order for the sample to run on Meta Headsets, the device must be placed in **Developer Mode**. Please refer to this [document](https://developer.android.com/studio/debug/dev-options) for how to perform such an action. This must be done for running the sample in the Unity Engine, making a build to run on Windows, or making a build directly to the headset (Meta Quest, Meta Quest 2, and Meta Quest Pro)


Is this valid for this sample?

…samples into mas12517/ARSample

…samples into mas12517/ARSample # Conflicts: # README.md # xr_sample_project/Assets/SampleViewer/SampleViewer.asmdef # xr_sample_project/ProjectSettings/EditorBuildSettings.asset

mmgaw113 and others added 30 commits October 4, 2024 07:42

Init

b2ad840

update logo

742e4a4

Revert package settings files

d3ca119

Fix Package Settings

75701e1

Update Sample

7cd4cf6

Update Sample

010dc56

Add button to spawn features

4420777

Update Sample

ad59402

Update Sample

1ccf3e6

update Gitignore to ignore android files.

8887cc3

Update XR Samples to Unity 6

5ca917c

Add mini-map for precise location tracking

dfe78a4

Update Project Settings, Tag Manager,And Build Settings

a523539

Add UI animations

8d7c204

Updates to the Sample

5ed4c95

Add Map Expanding

22c1c85

Minor Updates

9d94ea3

Remove Samples

186371d

Merge branch 'mas12517/Update-XR-Samples' of https://github.com/Esri/…

22ae43d

…arcgis-maps-sdk-unity-samples into mas12517/ARSample

Update UI

b182602

Merge branch 'main' of https://github.com/Esri/arcgis-maps-sdk-unity-…

36c4531

…samples into mas12517/ARSample

Update Sample UI

0b2bacf

Revert Changes to readme

048349c

Merge branch 'Release/1.7' of https://github.com/Esri/arcgis-maps-sdk…

0970abf

…-unity-samples into mas12517/ARSample

Merge branch 'Release/1.7' of https://github.com/Esri/arcgis-maps-sdk…

87273c7

…-unity-samples into mas12517/ARSample

Merge branch 'main' of https://github.com/Esri/arcgis-maps-sdk-unity-…

054e0d4

…samples into mas12517/ARSample

Merge branch 'Release/1.7' of https://github.com/Esri/arcgis-maps-sdk…

bd009b6

…-unity-samples into mas12517/ARSample

mmgaw113 added 3 commits November 26, 2024 09:05

Merge branch 'Release/1.7' of https://github.com/Esri/arcgis-maps-sdk…

ea7aff6

…-unity-samples into mas12517/ARSample

Adjust Scale to make feature objects smaller

cf5fe53

Add readme, rename folder

2e5d79c

mmgaw113 requested a review from a team November 26, 2024 17:50

mmgaw113 self-assigned this Nov 26, 2024

mmgaw113 changed the base branch from Release/1.7 to main November 26, 2024 21:12

ZackAllen reviewed Dec 2, 2024

View reviewed changes

mmgaw113 added 2 commits December 3, 2024 14:06

Address Feedback

f85a750

Address Feedback

05425d8

mmgaw113 marked this pull request as draft January 7, 2025 16:17

mmgaw113 and others added 4 commits January 9, 2025 13:33

Merge branch 'main' of https://github.com/Esri/arcgis-maps-sdk-unity-…

14076c5

…samples into mas12517/ARSample

Update sample

3db5b56

Merge branch 'main' of https://github.com/Esri/arcgis-maps-sdk-unity-…

eba5463

…samples into mas12517/ARSample # Conflicts: # README.md # xr_sample_project/Assets/SampleViewer/SampleViewer.asmdef # xr_sample_project/ProjectSettings/EditorBuildSettings.asset

Add loading screen, updating rotation setting

dea5fb4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

New Sample: AR Feature Layer#163

New Sample: AR Feature Layer#163
mmgaw113 wants to merge 39 commits into
mainfrom
mas12517/ARSample

mmgaw113 commented Nov 26, 2024

Uh oh!

ZackAllen left a comment

Uh oh!

Uh oh!

Uh oh!

ZackAllen Dec 2, 2024

Uh oh!

ZackAllen Dec 2, 2024

Uh oh!

mmgaw113 Dec 3, 2024

Uh oh!

Uh oh!

Uh oh!

ZackAllen Dec 2, 2024

Uh oh!

mmgaw113 Dec 3, 2024

Uh oh!

ZackAllen Dec 2, 2024

Uh oh!

mmgaw113 Dec 3, 2024

Uh oh!

ZackAllen Dec 2, 2024

Uh oh!

ZackAllen Dec 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mmgaw113 commented Nov 26, 2024

Uh oh!

ZackAllen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants