Update dependencies #1272
Update dependencies #1272
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
| IFeatureSet | ||
| } from "@esri/arcgis-rest-request"; | ||
|
|
||
| export interface IFeatureSetWithGeoJson extends IFeatureSet { |
There was a problem hiding this comment.
I'm interested as to what this is doing as I may have run into an overlapping type issue with the query library response that also extends this IFeatureSet, returning both geojson and arcgis under the features prop
There was a problem hiding this comment.
The routing methods work a little different and return a geoJson property next to a features property. I think what you are looking for is function overloads I cooked up something in #821 (comment) that I think we should look at for v5 since I think that changing the types would be a breaking change.
There was a problem hiding this comment.
That was a fantastic read and nice rabbit hole to jump down. Gives a lot of context
| export interface IGetApiKeyOptions extends Omit<IRequestOptions, "params"> { | ||
| /** | ||
| * {@linkcode IAuthenticationManager} authentication. | ||
| * {@linkcode @esri/arcgis-rest-request!IAuthenticationManager} authentication. |
There was a problem hiding this comment.
wow was this all it needed? :)
There was a problem hiding this comment.
Yup. It was buried in the doc on declaration references
noahmulfinger
left a comment
noahmulfinger
left a comment
There was a problem hiding this comment.
Typos and a few questions
| * | ||
| * A {@linkcode ArcGISAccessDeniedError} error will be thrown if the user denies the request on the authorization screen. | ||
| * | ||
| * @browserOnly |
There was a problem hiding this comment.
- So was support dropped for
@browserOnlyand@nodeOnlytags?\ - How will these typedoc changes affect our typedoc processing on the developer website?
There was a problem hiding this comment.
We never actually supported these on the developer website. We just moved this info into the comment.
RELEASE.md
Outdated
| As of v4, the ArcGIS REST JS packages are released automatically via Semantic Release. | ||
| In Late 2025 ArcGIS REST JS now uses [changesets](https://github.com/changesets/changesets) to manage releases. This happens automatically using the default [changeset action](https://github.com/changesets/action) in the [release workflow](./.github/workflows/release.yml). When changes are merge to `main` changesets will automatically creates a PR that when merged will trigges a new release of all packages. | ||
|
|
||
| As a part of these changes all versions of ArcGIS REST JS packages are how synced to the highest minor version accross all packages. All packages will now maintain the same version number for ease of reference. |
There was a problem hiding this comment.
Is it the case that "all packages will now maintain the same version number"? Isn't that dependent on the changeset keyword used (patch or minor)?
There was a problem hiding this comment.
Yes but they will all be bumped to the same version (patch/minor/major) together. Keeping everything on the same version will make things like the support lifecycles easier
Co-authored-by: Noah Mulfinger <[email protected]>
Co-authored-by: Noah Mulfinger <[email protected]>
Co-authored-by: Noah Mulfinger <[email protected]>
Minimum allowed line rate is |
Now that we are free from Karma and Jasmine (yay @dixonyant!) I've updated the dependencies for TypeScript, TypeDoc, ESLint and Rollup. This fixes problems with peer dependencies and means we can go back to normal
npm installinstead ofnpm install --legacy-peer-deps.this also makes a bunch of other changes including: