Skip to content

feat(radio-button-group): add component tokens #11897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2025
Merged

feat(radio-button-group): add component tokens #11897

merged 3 commits into from
Apr 22, 2025

Conversation

driskull
Copy link
Member

@driskull driskull commented Apr 8, 2025 •
edited
Loading

Related Issue: #7180

Summary

Adds the following tokens for radio-button-group component.

  • --calcite-radio-button-group-gap: Specifies the space between slotted components in the component.
  • --calcite-radio-button-input-message-spacing: Specifies the margin spacing at the top of the input-message component.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Apr 8, 2025
@driskull driskull marked this pull request as ready for review April 8, 2025 18:53
@driskull driskull mentioned this pull request Apr 8, 2025
Open
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 8, 2025
aPreciado88
aPreciado88 approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@aPreciado88 aPreciado88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 🚀

@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Apr 18, 2025
@driskull driskull merged commit ec0eeef into dev Apr 22, 2025
14 checks passed
@driskull driskull deleted the dris0000/radio-button-group-tokens branch April 22, 2025 16:22
@github-actions github-actions bot added this to the 2025-04-29 - Apr Milestone milestone Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aPreciado88 aPreciado88 aPreciado88 approved these changes

@Elijbet Elijbet Awaiting requested review from Elijbet

@macandcheese macandcheese Awaiting requested review from macandcheese

Assignees

@driskull driskull

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Milestone
2025-04-29 - Apr Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @aPreciado88