-
Notifications
You must be signed in to change notification settings - Fork 81
fix(list-item): align elements to the left of the item's content #11977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(list-item): align elements to the left of the item's content #11977
Conversation
|
@ashetland @SkyeSeitz Can you please take a look? |
jcfranco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM!
driskull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes look good 👍
| .drag-container, | ||
| .selection-container, | ||
| .expanded-container, | ||
| .actions-start { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this from actions-start. It is already inside the bordered container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weirdly, this doesn't seem to have worked anyway and I'm not seeing any related visual changes on action-start. I'm going to approve the PR, but we can still lose line 405.
…ciado88/11031-list-item-misaligned-elements
* origin/dev: (56 commits) feat(button): enhance component's interactivity states (#12005) chore: release next feat: add image display order web component icons (#11992) chore: release next fix(list-item): align elements to the left of the item's content (#11977) chore: release next fix(input, input-number, input-text, text-area, combobox): pass AA for placeholder text color (#11972) docs: update list of contributors (#11997) chore: release next fix(semantic-tokens): provide sufficient warning color contrast across components (#11994) chore: release next feat(tokens): update core neutral color values (#11993) docs: update list of contributors (#11988) chore: release next build(deps): update nx monorepo to v20.8.0 (#11986) build(deps): update arcgis to ^4.32.14 (#11931) chore: add design-tokens as dev dependency for Lerna updates (#11990) build(deps): update dependency @tokens-studio/sd-transforms to v1.3.0 (#11985) feat(tokens): add transparency-inverse tokens (#11974) chore: release next ...
Related Issue: #11031
Summary
Add bottom spacing to fix misalignment of elements to the left of the item's content.