Skip to content

Conversation

@aPreciado88
Copy link
Contributor

Related Issue: #11031

Summary

Add bottom spacing to fix misalignment of elements to the left of the item's content.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Apr 17, 2025
@aPreciado88 aPreciado88 added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 17, 2025
@aPreciado88
Copy link
Contributor Author

@ashetland @SkyeSeitz Can you please take a look?

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM!

@jcfranco jcfranco requested a review from driskull April 17, 2025 19:31
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good 👍

.drag-container,
.selection-container,
.expanded-container,
.actions-start {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this from actions-start. It is already inside the bordered container.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly, this doesn't seem to have worked anyway and I'm not seeing any related visual changes on action-start. I'm going to approve the PR, but we can still lose line 405.

@aPreciado88 aPreciado88 added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 21, 2025
@aPreciado88 aPreciado88 merged commit b0ee19d into dev Apr 21, 2025
13 checks passed
@aPreciado88 aPreciado88 deleted the aPreciado88/11031-list-item-misaligned-elements branch April 21, 2025 17:06
benelan added a commit that referenced this pull request Apr 21, 2025
* origin/dev: (56 commits)
  feat(button): enhance component's interactivity states (#12005)
  chore: release next
  feat: add image display order web component icons (#11992)
  chore: release next
  fix(list-item): align elements to the left of the item's content (#11977)
  chore: release next
  fix(input, input-number, input-text, text-area, combobox): pass AA for placeholder text color (#11972)
  docs: update list of contributors (#11997)
  chore: release next
  fix(semantic-tokens): provide sufficient warning color contrast across components (#11994)
  chore: release next
  feat(tokens): update core neutral color values (#11993)
  docs: update list of contributors (#11988)
  chore: release next
  build(deps): update nx monorepo to v20.8.0 (#11986)
  build(deps): update arcgis to ^4.32.14 (#11931)
  chore: add design-tokens as dev dependency for Lerna updates (#11990)
  build(deps): update dependency @tokens-studio/sd-transforms to v1.3.0 (#11985)
  feat(tokens): add transparency-inverse tokens (#11974)
  chore: release next
  ...
benelan pushed a commit that referenced this pull request May 14, 2025
)

**Related Issue:**
[#11031](#11031)

## Summary

Add bottom spacing to fix misalignment of elements to the left of the
item's content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants