fix(icon): enable support for deprecated icon color variable #13557
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
brendan-vincent-rice
added
the
pr ready for visual snapshots
19 tasks
anveshmekala
requested changes
Jan 6, 2026
Contributor
anveshmekala
left a comment
anveshmekala
left a comment
There was a problem hiding this comment.
Don't think this is required. color is applied at host with text-color-icon tailwind class.
Member
Author
@anveshmekala Great catch! Yes, this PR isn't necessary so I'll close it. Line 53 of
The following CodePen demonstrates this: |
Member
Author
|
This PR can be closed. The icon component already has support for the deprecated variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #13056
Summary
This PR enables support in the Icon component for the deprecated
--calcite-ui-icon-colorvariable. An end-to-end test already exists.