-
Notifications
You must be signed in to change notification settings - Fork 81
feat(split-button): add hover, focus and press background-color css custom property tokens #13588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat(split-button): add hover, focus and press background-color css custom property tokens #13588
Conversation
…ustom property tokens
isaacbraun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides some consistency doc changes.
packages/components/src/components/split-button/split-button.scss
Outdated
Show resolved
Hide resolved
SkyeSeitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lg2m!
matgalla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…lharper/13462-split-button-background-color-tokens
…lharper/13462-split-button-background-color-tokens
Related Issue: #13462
Summary
This PR adds the following css custom property tokens to
split-button:--calcite-split-button-background-color-hover--calcite-split-button-background-color-focus--calcite-split-button-background-color-press.