Skip to content

Conversation

@Amretasre002762670
Copy link
Contributor

Related Issue: #11666

Summary

Update scrim transparency values in light and dark design tokens for improved consistency and accessibility.

Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matgalla @Amretasre002762670 what should the title of this PR be? Should it be something like feat(tokens): update scrim token value?

@Amretasre002762670 Amretasre002762670 changed the title feat(scrim): update transparency for light and dark theme feat(tokens): update scrim transparency Jan 5, 2026
@matgalla matgalla added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 7, 2026
matgalla
matgalla previously approved these changes Jan 7, 2026
Copy link
Contributor

@matgalla matgalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but cc-ing @jcfranco for more eyes 👀

Copy link
Contributor

@matgalla matgalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pausing on this to revisit how these changes impact some component's loading visuals. cc @Esri/calcite-designers

@matgalla matgalla self-requested a review January 13, 2026 19:57
@matgalla matgalla dismissed their stale review January 13, 2026 22:00

Holding off on this change temporarily. The issue will be moved back to 1 - in design until a solution to the impacted loading visuals has been established.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants