Skip to content

Conversation

@isaacbraun
Copy link
Contributor

Related Issue: #11131

Summary

Adds paginationDisabled prop to support more custom/programmatic setups and the previous single-item behavior (changed by #12270).

@isaacbraun isaacbraun added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 15, 2026
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jan 15, 2026
Copy link
Member

@geospatialem geospatialem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, thanks for getting to this feat so quick, @isaacbraun! Had one doc suggestion for consideration

Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question for translation.

isaacbraun added a commit that referenced this pull request Jan 15, 2026
**Related Issue:** #11131

## Summary
Adds the `paginationStatus` string to messages for use with the
`aria-live` information when `paginationDisabled`.

Required before #13704 can be installed.
@isaacbraun isaacbraun force-pushed the isaacbraun/11131-add-pagination-disabled branch from be99bfb to 4853114 Compare January 15, 2026 23:04
@isaacbraun isaacbraun added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 15, 2026
@isaacbraun isaacbraun added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 15, 2026
Copy link
Contributor

@anveshmekala anveshmekala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the translations being back from either of generate or real build, installing code related to messages.paginationStatus can lead to run time errors.

Test failures are related to messages.paginationStatus being undefined and the current version still refers to old messages property. To avoid such please merge from default branch once #13710 is installed.

Avoid installing this PR before generate build changes are installed in dev branch.

@isaacbraun isaacbraun added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 16, 2026
@isaacbraun isaacbraun added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 16, 2026
Copy link
Contributor

@anveshmekala anveshmekala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@isaacbraun isaacbraun added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 16, 2026
@isaacbraun isaacbraun merged commit efd2573 into dev Jan 16, 2026
14 checks passed
@isaacbraun isaacbraun deleted the isaacbraun/11131-add-pagination-disabled branch January 16, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants