-
Notifications
You must be signed in to change notification settings - Fork 81
feat(carousel): add paginationDisabled property
#13704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
geospatialem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo, thanks for getting to this feat so quick, @isaacbraun! Had one doc suggestion for consideration
macandcheese
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a question for translation.
be99bfb to
4853114
Compare
anveshmekala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the translations being back from either of generate or real build, installing code related to messages.paginationStatus can lead to run time errors.
Test failures are related to messages.paginationStatus being undefined and the current version still refers to old messages property. To avoid such please merge from default branch once #13710 is installed.
Avoid installing this PR before generate build changes are installed in dev branch.
anveshmekala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Related Issue: #11131
Summary
Adds
paginationDisabledprop to support more custom/programmatic setups and the previous single-item behavior (changed by #12270).